fix(ViewOnlyPlugin): Allow COPY and MOVE operations within the same storage#61497
Draft
provokateurin wants to merge 2 commits into
Draft
fix(ViewOnlyPlugin): Allow COPY and MOVE operations within the same storage#61497provokateurin wants to merge 2 commits into
provokateurin wants to merge 2 commits into
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
…torage Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
Altahrim,
ArtificialOwl and
come-nc
and removed request for
a team
provokateurin
changed the title
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
provokateurin
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checks are only supposed to block copying and moving files out of the share, as that would allow to circumvent the "allow download and sync" restriction. However they applied to all operations regardless of the destination and therefore blocked legitimate copying and moving within the same share.